GH-48094: [C++] Restrict SecureString capacity tail check to Linux - #49906
Conversation
|
|
|
cc @pitrou thanks |
|
Can we condition this on MSVC rather than Linux? The test can still be used under macOS and other platforms. |
69d0341 to
1416cc9
Compare
1416cc9 to
1279689
Compare
|
done thanks |
|
Oops, I should have changed the PR title before merging. Too late. |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 25e4fdb. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 25e4fdb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…nux (apache#49906) ### Rationale for this change - The test reads the unused tail of string past size(), which is undefined. libstdc++ keeps that range addressable, but MSVC does not. - Ensure the check is not run for MSVC. Existing assertions still run, the unused capacity is not asserted on non linux platforms. - Closes apache#48094. ### What changes are included in this PR? - Guard for platform specific behavior. ### Are these changes tested? - Yes ### Are there any user-facing changes? - Yes * GitHub Issue: apache#48094 Authored-by: Arnav Balyan <arnavbalyan1@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
2 participants
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?